leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

media: pci: saa7164-vbi.c: replace if (cond) BUG() with BUG_ON()

Browse Source 
Fix the following coccinelle reports:

drivers/media/pci/saa7164/saa7164-vbi.c:707:2-5:
WARNING: Use BUG_ON instead of if condition followed by BUG.

drivers/media/pci/saa7164/saa7164-vbi.c:760:2-5:
WARNING: Use BUG_ON instead of if condition followed by BUG.

Found using - Coccinelle (http://coccinelle.lip6.fr)

Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
This commit is contained in:
Daniel W. S. Almeida 2020-08-07 10:35:37 +02:00 committed by Mauro Carvalho Chehab
parent a1bb5cca58
commit d8018ec175
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/media/pci/saa7164/saa7164-vbi.c
View File

@ -703,8 +703,7 @@ int saa7164_vbi_register(struct saa7164_port *port)
dprintk(DBGLVL_VBI, "%s()\n", __func__); dprintk(DBGLVL_VBI, "%s()\n", __func__);
if (port->type != SAA7164_MPEG_VBI) BUG_ON(port->type != SAA7164_MPEG_VBI);
BUG();
/* Sanity check that the PCI configuration space is active */ /* Sanity check that the PCI configuration space is active */
if (port->hwcfg.BARLocation == 0) { if (port->hwcfg.BARLocation == 0) {
@ -756,8 +755,7 @@ void saa7164_vbi_unregister(struct saa7164_port *port)
dprintk(DBGLVL_VBI, "%s(port=%d)\n", __func__, port->nr); dprintk(DBGLVL_VBI, "%s(port=%d)\n", __func__, port->nr);
if (port->type != SAA7164_MPEG_VBI) BUG_ON(port->type != SAA7164_MPEG_VBI);
BUG();
if (port->v4l_device) { if (port->v4l_device) {
if (port->v4l_device->minor != -1) if (port->v4l_device->minor != -1)