leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

perf machine: Factor machine__find_thread to take tid argument

Browse Source 
Forcing the code to always search thread by pid/tid pair.

The PID value will be needed in future to determine the process thread
leader for map groups sharing.

Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1394805606-25883-3-git-send-email-jolsa@redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Jiri Olsa
2014-03-14 15:00:03 +01:00
committed by Arnaldo Carvalho de Melo
parent 363b785f38
commit d75e6097ef
3 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tools/perf/tests/dwarf-unwind.c
View File

@@ -128,7 +128,7 @@ int test__dwarf_unwind(void)
if (verbose > 1) if (verbose > 1)
machine__fprintf(machine, stderr); machine__fprintf(machine, stderr);
thread = machine__find_thread(machine, getpid()); thread = machine__find_thread(machine, getpid(), getpid());
if (!thread) { if (!thread) {
pr_err("Could not get thread\n"); pr_err("Could not get thread\n");
goto out; goto out;

13
tools/perf/util/machine.c
View File

@@ -327,9 +327,10 @@ struct thread *machine__findnew_thread(struct machine *machine, pid_t pid,
return __machine__findnew_thread(machine, pid, tid, true); return __machine__findnew_thread(machine, pid, tid, true);
} }
struct thread *machine__find_thread(struct machine *machine, pid_t tid) struct thread *machine__find_thread(struct machine *machine, pid_t pid,
pid_t tid)
{ {
return __machine__findnew_thread(machine, 0, tid, false); return __machine__findnew_thread(machine, pid, tid, false);
} }
int machine__process_comm_event(struct machine *machine, union perf_event *event, int machine__process_comm_event(struct machine *machine, union perf_event *event,
@@ -1114,7 +1115,9 @@ static void machine__remove_thread(struct machine *machine, struct thread *th)
int machine__process_fork_event(struct machine *machine, union perf_event *event, int machine__process_fork_event(struct machine *machine, union perf_event *event,
struct perf_sample *sample) struct perf_sample *sample)
{ {
struct thread *thread = machine__find_thread(machine, event->fork.tid); struct thread *thread = machine__find_thread(machine,
event->fork.pid,
event->fork.tid);
struct thread *parent = machine__findnew_thread(machine, struct thread *parent = machine__findnew_thread(machine,
event->fork.ppid, event->fork.ppid,
event->fork.ptid); event->fork.ptid);
@@ -1140,7 +1143,9 @@ int machine__process_fork_event(struct machine *machine, union perf_event *event
int machine__process_exit_event(struct machine *machine, union perf_event *event, int machine__process_exit_event(struct machine *machine, union perf_event *event,
struct perf_sample *sample __maybe_unused) struct perf_sample *sample __maybe_unused)
{ {
struct thread *thread = machine__find_thread(machine, event->fork.tid); struct thread *thread = machine__find_thread(machine,
event->fork.pid,
event->fork.tid);
if (dump_trace) if (dump_trace)
perf_event__fprintf_task(event, stdout); perf_event__fprintf_task(event, stdout);

3
tools/perf/util/machine.h
View File

@@ -41,7 +41,8 @@ struct map *machine__kernel_map(struct machine *machine, enum map_type type)
return machine->vmlinux_maps[type]; return machine->vmlinux_maps[type];
} }
struct thread *machine__find_thread(struct machine *machine, pid_t tid); struct thread *machine__find_thread(struct machine *machine, pid_t pid,
pid_t tid);
int machine__process_comm_event(struct machine *machine, union perf_event *event, int machine__process_comm_event(struct machine *machine, union perf_event *event,
struct perf_sample *sample); struct perf_sample *sample);