leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ALSA: core: Deletion of unnecessary checks before two function calls

Browse Source 
The functions snd_seq_oss_timer_delete() and vunmap() perform also input
parameter validation. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Markus Elfring
2014-11-21 18:34:48 +01:00
committed by Takashi Iwai
parent eaa8e5ef18
commit d712eaf29d
2 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
sound/core/seq/oss/seq_oss_init.c
View File

@@ -403,13 +403,10 @@ free_devinfo(void *private)
{ {
struct seq_oss_devinfo *dp = (struct seq_oss_devinfo *)private; struct seq_oss_devinfo *dp = (struct seq_oss_devinfo *)private;
if (dp->timer)
snd_seq_oss_timer_delete(dp->timer); snd_seq_oss_timer_delete(dp->timer);
if (dp->writeq)
snd_seq_oss_writeq_delete(dp->writeq); snd_seq_oss_writeq_delete(dp->writeq);
if (dp->readq)
snd_seq_oss_readq_delete(dp->readq); snd_seq_oss_readq_delete(dp->readq);
kfree(dp); kfree(dp);

1
sound/core/sgbuf.c
View File

@@ -39,7 +39,6 @@ int snd_free_sgbuf_pages(struct snd_dma_buffer *dmab)
if (! sgbuf) if (! sgbuf)
return -EINVAL; return -EINVAL;
if (dmab->area)
vunmap(dmab->area); vunmap(dmab->area);
dmab->area = NULL; dmab->area = NULL;