leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

usb: renesas-xhci: remove version check

Browse Source 
Some devices in wild are reporting bunch of firmware versions, so remove
the check for versions in driver

Reported by: Anastasios Vacharakis <vacharakis@gmail.com>
Reported by: Glen Journeay <journeay@gmail.com>
Fixes: 2478be82de ("usb: renesas-xhci: Add ROM loader for uPD720201")
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=208911
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20200818071739.789720-1-vkoul@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Vinod Koul
2020-08-18 12:47:39 +05:30
committed by Greg Kroah-Hartman
parent 531412492c
commit d66a57be2f
1 changed files with 1 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
drivers/usb/host/xhci-pci-renesas.c
View File

@@ -50,20 +50,6 @@
#define RENESAS_RETRY 10000 #define RENESAS_RETRY 10000
#define RENESAS_DELAY 10 #define RENESAS_DELAY 10
#define ROM_VALID_01 0x2013
#define ROM_VALID_02 0x2026
static int renesas_verify_fw_version(struct pci_dev *pdev, u32 version)
{
switch (version) {
case ROM_VALID_01:
case ROM_VALID_02:
return 0;
}
dev_err(&pdev->dev, "FW has invalid version :%d\n", version);
return -EINVAL;
}
static int renesas_fw_download_image(struct pci_dev *dev, static int renesas_fw_download_image(struct pci_dev *dev,
const u32 *fw, size_t step, bool rom) const u32 *fw, size_t step, bool rom)
{ {
@@ -202,10 +188,7 @@ static int renesas_check_rom_state(struct pci_dev *pdev)
version &= RENESAS_FW_VERSION_FIELD; version &= RENESAS_FW_VERSION_FIELD;
version = version >> RENESAS_FW_VERSION_OFFSET; version = version >> RENESAS_FW_VERSION_OFFSET;
dev_dbg(&pdev->dev, "Found ROM version: %x\n", version);
err = renesas_verify_fw_version(pdev, version);
if (err)
return err;
/* /*
* Test if ROM is present and loaded, if so we can skip everything * Test if ROM is present and loaded, if so we can skip everything