leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

net/sunrpc: return 0 on attempt to write to "transports"

Browse Source 
You can't write to this file because the permissions are 0444.  But
it sort of looked like you could do a write and it would result in
a read.  Then it looked like proc_sys_call_handler() just ignored
it.  Which is confusing.  It's more clear if the "write" just
returns zero.

Also, the "lenp" pointer is never NULL so that check can be removed.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
This commit is contained in:
Dan Carpenter
2020-11-06 15:39:50 -05:00
committed by J. Bruce Fields
parent 49a3613273
commit d435c05ab0
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
net/sunrpc/sysctl.c
View File

@@ -65,7 +65,7 @@ static int proc_do_xprt(struct ctl_table *table, int write,
char tmpbuf[256]; char tmpbuf[256];
size_t len; size_t len;
if ((*ppos && !write) || !*lenp) { if (write || *ppos) {
*lenp = 0; *lenp = 0;
return 0; return 0;
} }