leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

xfs: clean up inode state flag tests in xfs_blockgc_igrab

Browse Source 
Clean up the definition of which inode states are not eligible for
speculative preallocation garbage collecting by creating a private
#define.  The deferred inactivation patchset will add two new entries to
the set of flags-to-ignore, so we want the definition not to end up a
cluttered mess.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
This commit is contained in:
Darrick J. Wong
2021-06-01 23:01:44 -07:00
parent f427cf5c62
commit d20d5edcf9
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
fs/xfs/xfs_icache.c
View File

@@ -1533,6 +1533,10 @@ xfs_blockgc_start(
xfs_blockgc_queue(pag); xfs_blockgc_queue(pag);
} }
/* Don't try to run block gc on an inode that's in any of these states. */
#define XFS_BLOCKGC_NOGRAB_IFLAGS (XFS_INEW | \
XFS_IRECLAIMABLE | \
XFS_IRECLAIM)
/* /*
* Decide if the given @ip is eligible for garbage collection of speculative * Decide if the given @ip is eligible for garbage collection of speculative
* preallocations, and grab it if so. Returns true if it's ready to go or * preallocations, and grab it if so. Returns true if it's ready to go or
@@ -1551,8 +1555,7 @@ xfs_blockgc_igrab(
if (!ip->i_ino) if (!ip->i_ino)
goto out_unlock_noent; goto out_unlock_noent;
/* avoid new or reclaimable inodes. Leave for reclaim code to flush */ if (ip->i_flags & XFS_BLOCKGC_NOGRAB_IFLAGS)
if (__xfs_iflags_test(ip, XFS_INEW | XFS_IRECLAIMABLE | XFS_IRECLAIM))
goto out_unlock_noent; goto out_unlock_noent;
spin_unlock(&ip->i_flags_lock); spin_unlock(&ip->i_flags_lock);