leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

serial: mctrl_gpio: add IRQ locking

Browse Source 
uart_handle_cts_change should be called with port->lock held. And for
this to be save you must also disable irqs.

Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Yegor Yefremov
2016-04-29 10:45:07 +02:00
committed by Greg Kroah-Hartman
parent fa01e2ca9f
commit d11df61853
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/tty/serial/serial_mctrl_gpio.c
View File

@@ -125,9 +125,12 @@ static irqreturn_t mctrl_gpio_irq_handle(int irq, void *context)
struct uart_port *port = gpios->port; struct uart_port *port = gpios->port;
u32 mctrl = gpios->mctrl_prev; u32 mctrl = gpios->mctrl_prev;
u32 mctrl_diff; u32 mctrl_diff;
unsigned long flags;
mctrl_gpio_get(gpios, &mctrl); mctrl_gpio_get(gpios, &mctrl);
spin_lock_irqsave(&port->lock, flags);
mctrl_diff = mctrl ^ gpios->mctrl_prev; mctrl_diff = mctrl ^ gpios->mctrl_prev;
gpios->mctrl_prev = mctrl; gpios->mctrl_prev = mctrl;
@@ -147,6 +150,8 @@ static irqreturn_t mctrl_gpio_irq_handle(int irq, void *context)
wake_up_interruptible(&port->state->port.delta_msr_wait); wake_up_interruptible(&port->state->port.delta_msr_wait);
} }
spin_unlock_irqrestore(&port->lock, flags);
return IRQ_HANDLED; return IRQ_HANDLED;
} }