leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

neigh: no need to call lookup_neigh_parms in neigh_parms_alloc

Browse Source 
neigh_table.parms always exist and is initialized,kmemdup
can use it to create new neigh_parms, actually lookup_neigh_parms
here will return neigh_table.parms too.

Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Gao feng 2013-06-20 10:01:32 +08:00 committed by David S. Miller
parent 75b2945988
commit cf89d6b280
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
net/core/neighbour.c
View File

@ -1429,15 +1429,11 @@ static inline struct neigh_parms *lookup_neigh_parms(struct neigh_table *tbl,
struct neigh_parms *neigh_parms_alloc(struct net_device *dev, struct neigh_parms *neigh_parms_alloc(struct net_device *dev,
struct neigh_table *tbl) struct neigh_table *tbl)
{ {
struct neigh_parms *p, *ref; struct neigh_parms *p;
struct net *net = dev_net(dev); struct net *net = dev_net(dev);
const struct net_device_ops *ops = dev->netdev_ops; const struct net_device_ops *ops = dev->netdev_ops;
ref = lookup_neigh_parms(tbl, net, 0); p = kmemdup(&tbl->parms, sizeof(*p), GFP_KERNEL);
if (!ref)
return NULL;
p = kmemdup(ref, sizeof(*p), GFP_KERNEL);
if (p) { if (p) {
p->tbl = tbl; p->tbl = tbl;
atomic_set(&p->refcnt, 1); atomic_set(&p->refcnt, 1);