leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pinctrl: baytrail: Add missing spinlock usage in byt_gpio_irq_handler

Browse Source 
According to VLI64 Intel Atom E3800 Specification Update (#329901)
concurrent read accesses may result in returning 0xffffffff and write
accesses may be dropped silently.
To workaround all accesses must be protected by locks.

Cc: stable@vger.kernel.org
Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Alexander Stein 2017-01-30 12:35:28 +01:00 committed by Linus Walleij
parent 1b89970d81
commit cdca06e4e8
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/pinctrl/intel/pinctrl-baytrail.c
View File

@ -1623,7 +1623,9 @@ static void byt_gpio_irq_handler(struct irq_desc *desc)
continue; continue;
} }
raw_spin_lock(&vg->lock);
pending = readl(reg); pending = readl(reg);
raw_spin_unlock(&vg->lock);
for_each_set_bit(pin, &pending, 32) { for_each_set_bit(pin, &pending, 32) {
virq = irq_find_mapping(vg->chip.irqdomain, base + pin); virq = irq_find_mapping(vg->chip.irqdomain, base + pin);
generic_handle_irq(virq); generic_handle_irq(virq);