leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[PATCH] Signedness issue in drivers/net/3c515.c

Browse Source 
while playing with gcc 4.1 -Wextra warnings, I came across this one:

drivers/net/3c515.c:1027: warning: comparison of unsigned expression >= 0 is always true

Since i is unsigned the >= 0 check in the for loop is always true,
so we might spin there forever unless the if condition triggers.
Since i is only used in this loop, this patch changes it to
an integer.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
This commit is contained in:
Eric Sesterhenn 2006-08-19 19:37:57 +02:00 committed by Jeff Garzik
parent a76b044af1
commit cb958186ed
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/net/3c515.c
View File

@ -1003,7 +1003,8 @@ static int corkscrew_start_xmit(struct sk_buff *skb,
/* Calculate the next Tx descriptor entry. */ /* Calculate the next Tx descriptor entry. */
int entry = vp->cur_tx % TX_RING_SIZE; int entry = vp->cur_tx % TX_RING_SIZE;
struct boom_tx_desc *prev_entry; struct boom_tx_desc *prev_entry;
unsigned long flags, i; unsigned long flags;
int i;
if (vp->tx_full) /* No room to transmit with */ if (vp->tx_full) /* No room to transmit with */
return 1; return 1;