leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fanotify: Simplify cleaning of access_list

Browse Source 
Simplify iteration cleaning access_list in fanotify_release(). That will
make following changes more obvious.

Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
This commit is contained in:
Jan Kara 2019-01-09 13:21:01 +01:00
parent f7db89accc
commit ca6f86998d
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
fs/notify/fanotify/fanotify_user.c
View File

@ -404,7 +404,7 @@ static ssize_t fanotify_write(struct file *file, const char __user *buf, size_t
static int fanotify_release(struct inode *ignored, struct file *file) static int fanotify_release(struct inode *ignored, struct file *file)
{ {
struct fsnotify_group *group = file->private_data; struct fsnotify_group *group = file->private_data;
struct fanotify_perm_event *event, *next; struct fanotify_perm_event *event;
struct fsnotify_event *fsn_event; struct fsnotify_event *fsn_event;
/* /*
@ -419,11 +419,9 @@ static int fanotify_release(struct inode *ignored, struct file *file)
* and simulate reply from userspace. * and simulate reply from userspace.
*/ */
spin_lock(&group->notification_lock); spin_lock(&group->notification_lock);
list_for_each_entry_safe(event, next, &group->fanotify_data.access_list, while (!list_empty(&group->fanotify_data.access_list)) {
fae.fse.list) { event = list_first_entry(&group->fanotify_data.access_list,
pr_debug("%s: found group=%p event=%p\n", __func__, group, struct fanotify_perm_event, fae.fse.list);
event);
list_del_init(&event->fae.fse.list); list_del_init(&event->fae.fse.list);
event->response = FAN_ALLOW; event->response = FAN_ALLOW;
} }