forked from Minki/linux
perf tools: make -C consistent across commands (for cpu list arg)
Currently the meaning of -C varies by perf command: for perf-top, perf-stat, perf-record it means cpu list. For perf-report it means comm list. Then perf-annotate, perf-report and perf-script use -c for cpu list. Fix annotate, report and script to use -C for cpu list to be consistent with top, stat and record. This means report needs to use -c for comm list which does introduce a backward compatibility change. v1 -> v2 - update perf-script.txt too Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Peter Zijlstra <peterz@infradead.org> Link: http://lkml.kernel.org/r/1321209008-7004-1-git-send-email-dsahern@gmail.com Signed-off-by: David Ahern <dsahern@gmail.com> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
parent
1758af10cf
commit
c8e6672035
@ -66,7 +66,7 @@ OPTIONS
|
|||||||
used. This interfaces starts by centering on the line with more
|
used. This interfaces starts by centering on the line with more
|
||||||
samples, TAB/UNTAB cycles through the lines with more samples.
|
samples, TAB/UNTAB cycles through the lines with more samples.
|
||||||
|
|
||||||
-c::
|
-C::
|
||||||
--cpu:: Only report samples for the list of CPUs provided. Multiple CPUs can
|
--cpu:: Only report samples for the list of CPUs provided. Multiple CPUs can
|
||||||
be provided as a comma-separated list with no space: 0,1. Ranges of
|
be provided as a comma-separated list with no space: 0,1. Ranges of
|
||||||
CPUs are specified with -: 0-2. Default is to report samples on all
|
CPUs are specified with -: 0-2. Default is to report samples on all
|
||||||
|
@ -39,7 +39,7 @@ OPTIONS
|
|||||||
-T::
|
-T::
|
||||||
--threads::
|
--threads::
|
||||||
Show per-thread event counters
|
Show per-thread event counters
|
||||||
-C::
|
-c::
|
||||||
--comms=::
|
--comms=::
|
||||||
Only consider symbols in these comms. CSV that understands
|
Only consider symbols in these comms. CSV that understands
|
||||||
file://filename entries.
|
file://filename entries.
|
||||||
@ -128,7 +128,7 @@ OPTIONS
|
|||||||
--symfs=<directory>::
|
--symfs=<directory>::
|
||||||
Look for files with symbols relative to this directory.
|
Look for files with symbols relative to this directory.
|
||||||
|
|
||||||
-c::
|
-C::
|
||||||
--cpu:: Only report samples for the list of CPUs provided. Multiple CPUs can
|
--cpu:: Only report samples for the list of CPUs provided. Multiple CPUs can
|
||||||
be provided as a comma-separated list with no space: 0,1. Ranges of
|
be provided as a comma-separated list with no space: 0,1. Ranges of
|
||||||
CPUs are specified with -: 0-2. Default is to report samples on all
|
CPUs are specified with -: 0-2. Default is to report samples on all
|
||||||
|
@ -182,7 +182,7 @@ OPTIONS
|
|||||||
--hide-call-graph::
|
--hide-call-graph::
|
||||||
When printing symbols do not display call chain.
|
When printing symbols do not display call chain.
|
||||||
|
|
||||||
-c::
|
-C::
|
||||||
--cpu:: Only report samples for the list of CPUs provided. Multiple CPUs can
|
--cpu:: Only report samples for the list of CPUs provided. Multiple CPUs can
|
||||||
be provided as a comma-separated list with no space: 0,1. Ranges of
|
be provided as a comma-separated list with no space: 0,1. Ranges of
|
||||||
CPUs are specified with -: 0-2. Default is to report samples on all
|
CPUs are specified with -: 0-2. Default is to report samples on all
|
||||||
|
@ -274,7 +274,7 @@ int cmd_annotate(int argc, const char **argv, const char *prefix __used)
|
|||||||
"print matching source lines (may be slow)"),
|
"print matching source lines (may be slow)"),
|
||||||
OPT_BOOLEAN('P', "full-paths", &annotate.full_paths,
|
OPT_BOOLEAN('P', "full-paths", &annotate.full_paths,
|
||||||
"Don't shorten the displayed pathnames"),
|
"Don't shorten the displayed pathnames"),
|
||||||
OPT_STRING('c', "cpu", &annotate.cpu_list, "cpu", "list of cpus to profile"),
|
OPT_STRING('C', "cpu", &annotate.cpu_list, "cpu", "list of cpus to profile"),
|
||||||
OPT_STRING(0, "symfs", &symbol_conf.symfs, "directory",
|
OPT_STRING(0, "symfs", &symbol_conf.symfs, "directory",
|
||||||
"Look for files with symbols relative to this directory"),
|
"Look for files with symbols relative to this directory"),
|
||||||
OPT_BOOLEAN(0, "source", &symbol_conf.annotate_src,
|
OPT_BOOLEAN(0, "source", &symbol_conf.annotate_src,
|
||||||
|
@ -492,7 +492,7 @@ int cmd_report(int argc, const char **argv, const char *prefix __used)
|
|||||||
"alias for inverted call graph"),
|
"alias for inverted call graph"),
|
||||||
OPT_STRING('d', "dsos", &symbol_conf.dso_list_str, "dso[,dso...]",
|
OPT_STRING('d', "dsos", &symbol_conf.dso_list_str, "dso[,dso...]",
|
||||||
"only consider symbols in these dsos"),
|
"only consider symbols in these dsos"),
|
||||||
OPT_STRING('C', "comms", &symbol_conf.comm_list_str, "comm[,comm...]",
|
OPT_STRING('c', "comms", &symbol_conf.comm_list_str, "comm[,comm...]",
|
||||||
"only consider symbols in these comms"),
|
"only consider symbols in these comms"),
|
||||||
OPT_STRING('S', "symbols", &symbol_conf.sym_list_str, "symbol[,symbol...]",
|
OPT_STRING('S', "symbols", &symbol_conf.sym_list_str, "symbol[,symbol...]",
|
||||||
"only consider these symbols"),
|
"only consider these symbols"),
|
||||||
@ -506,7 +506,7 @@ int cmd_report(int argc, const char **argv, const char *prefix __used)
|
|||||||
"Only display entries resolved to a symbol"),
|
"Only display entries resolved to a symbol"),
|
||||||
OPT_STRING(0, "symfs", &symbol_conf.symfs, "directory",
|
OPT_STRING(0, "symfs", &symbol_conf.symfs, "directory",
|
||||||
"Look for files with symbols relative to this directory"),
|
"Look for files with symbols relative to this directory"),
|
||||||
OPT_STRING('c', "cpu", &report.cpu_list, "cpu",
|
OPT_STRING('C', "cpu", &report.cpu_list, "cpu",
|
||||||
"list of cpus to profile"),
|
"list of cpus to profile"),
|
||||||
OPT_BOOLEAN('I', "show-info", &report.show_full_info,
|
OPT_BOOLEAN('I', "show-info", &report.show_full_info,
|
||||||
"Display extended information about perf.data file"),
|
"Display extended information about perf.data file"),
|
||||||
|
@ -1085,7 +1085,7 @@ static const struct option options[] = {
|
|||||||
OPT_CALLBACK('f', "fields", NULL, "str",
|
OPT_CALLBACK('f', "fields", NULL, "str",
|
||||||
"comma separated output fields prepend with 'type:'. Valid types: hw,sw,trace,raw. Fields: comm,tid,pid,time,cpu,event,trace,ip,sym,dso,addr",
|
"comma separated output fields prepend with 'type:'. Valid types: hw,sw,trace,raw. Fields: comm,tid,pid,time,cpu,event,trace,ip,sym,dso,addr",
|
||||||
parse_output_fields),
|
parse_output_fields),
|
||||||
OPT_STRING('c', "cpu", &cpu_list, "cpu", "list of cpus to profile"),
|
OPT_STRING('C', "cpu", &cpu_list, "cpu", "list of cpus to profile"),
|
||||||
OPT_BOOLEAN('I', "show-info", &show_full_info,
|
OPT_BOOLEAN('I', "show-info", &show_full_info,
|
||||||
"display extended information from perf.data file"),
|
"display extended information from perf.data file"),
|
||||||
OPT_END()
|
OPT_END()
|
||||||
|
Loading…
Reference in New Issue
Block a user