leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

net: hisilicon: remove unexpected free_netdev

Browse Source 
The net device ndev is freed via free_netdev when failing to register
the device. The control flow then jumps to the error handling code
block. ndev is used and freed again. Resulting in a use-after-free bug.

Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Pan Bian 2018-11-28 15:30:24 +08:00 committed by David S. Miller
parent cfc435198f
commit c758940158
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/ethernet/hisilicon/hip04_eth.c
View File

@ -915,10 +915,8 @@ static int hip04_mac_probe(struct platform_device *pdev)
} }
ret = register_netdev(ndev); ret = register_netdev(ndev);
if (ret) { if (ret)
free_netdev(ndev);
goto alloc_fail; goto alloc_fail;
}
return 0; return 0;