leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

staging: rtl8723bs: remove a couple of redundant initializations

Browse Source 
The initialization of PwrCfgCmd is redundant as the value is never read
and it is being re-assigned to PwrSeqCmd[AryIdx] inside a loop, hence
it can be removed.  Also, the initialization of ie_ptr is redundant as
the value is never read and it is being re-assigned in either path of
an if statement, hence it can be removed too.

Cleans up clang warnings:
drivers/staging/rtl8723bs/hal/HalPwrSeqCmd.c:53:15: warning: Value
stored to 'PwrCfgCmd' during its initialization is never read
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:374:7: warning: Value
stored to 'ie_ptr' during its initialization is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Colin Ian King 2018-01-26 11:54:14 +00:00 committed by Greg Kroah-Hartman
parent 26311087d1
commit c5f6911752
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/staging/rtl8723bs/hal/HalPwrSeqCmd.c
View File

@ -50,7 +50,7 @@ u8 HalPwrSeqCmdParsing(
WLAN_PWR_CFG PwrSeqCmd[] WLAN_PWR_CFG PwrSeqCmd[]
) )
{ {
WLAN_PWR_CFG PwrCfgCmd = {0}; WLAN_PWR_CFG PwrCfgCmd;
u8 bPollingBit = false; u8 bPollingBit = false;
u32 AryIdx = 0; u32 AryIdx = 0;
u8 value = 0; u8 value = 0;

2
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
View File

@ -371,7 +371,7 @@ static char *translate_scan(struct adapter *padapter,
u8 *wpsie_ptr = NULL; u8 *wpsie_ptr = NULL;
uint wps_ielen = 0; uint wps_ielen = 0;
u8 *ie_ptr = pnetwork->network.IEs + ie_offset; u8 *ie_ptr;
total_ielen = pnetwork->network.IELength - ie_offset; total_ielen = pnetwork->network.IELength - ie_offset;
if (pnetwork->network.Reserved[0] == 2) { /* Probe Request */ if (pnetwork->network.Reserved[0] == 2) { /* Probe Request */