leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

NFC: Move the pn544_hci dereference below the NULL test

Browse Source 
The dereference should be moved below the NULL test.

spatch with a semantic match is used to found this.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
This commit is contained in:
Wei Yongjun 2012-09-08 21:19:44 +08:00 committed by Samuel Ortiz
parent d6650a2ccf
commit c51ad34e54
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/nfc/pn544_hci.c
View File

@ -346,13 +346,16 @@ flush:
static irqreturn_t pn544_hci_irq_thread_fn(int irq, void *dev_id) static irqreturn_t pn544_hci_irq_thread_fn(int irq, void *dev_id)
{ {
struct pn544_hci_info *info = dev_id; struct pn544_hci_info *info = dev_id;
struct i2c_client *client = info->i2c_dev; struct i2c_client *client;
struct sk_buff *skb = NULL; struct sk_buff *skb = NULL;
int r; int r;
BUG_ON(!info); if (!info || irq != info->i2c_dev->irq) {
BUG_ON(irq != info->i2c_dev->irq); WARN_ON_ONCE(1);
return IRQ_NONE;
}
client = info->i2c_dev;
dev_dbg(&client->dev, "IRQ\n"); dev_dbg(&client->dev, "IRQ\n");
if (info->hard_fault != 0) if (info->hard_fault != 0)