leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ALSA: intel_hdmi: Use strlcpy() instead of strncpy()

Browse Source 
hdmi_lpe_audio_probe() copies the pcm name string via strncpy(), but
as a gcc8 warning suggests, it misses a NUL terminator, and unlikely
the expected result.

Use the proper one, strlcpy() instead.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Takashi Iwai 2018-06-27 14:59:00 +02:00
parent 401caff70c
commit c288248f5b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sound/x86/intel_hdmi_audio.c
View File

@ -1854,7 +1854,7 @@ static int hdmi_lpe_audio_probe(struct platform_device *pdev)
/* setup private data which can be retrieved when required */ /* setup private data which can be retrieved when required */
pcm->private_data = ctx; pcm->private_data = ctx;
pcm->info_flags = 0; pcm->info_flags = 0;
strncpy(pcm->name, card->shortname, strlen(card->shortname)); strlcpy(pcm->name, card->shortname, strlen(card->shortname));
/* setup the ops for playabck */ /* setup the ops for playabck */
snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_PLAYBACK, &had_pcm_ops); snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_PLAYBACK, &had_pcm_ops);