leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

kunit: Taint the kernel when KUnit tests are run

Browse Source 
Make KUnit trigger the new TAINT_TEST taint when any KUnit test is run.
Due to KUnit tests not being intended to run on production systems, and
potentially causing problems (or security issues like leaking kernel
addresses), the kernel's state should not be considered safe for
production use after KUnit tests are run.

This both marks KUnit modules as test modules using MODULE_INFO() and
manually taints the kernel when tests are run (which catches builtin
tests).

Acked-by: Luis Chamberlain <mcgrof@kernel.org>
Tested-by: Daniel Latypov <dlatypov@google.com>
Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
Signed-off-by: David Gow <davidgow@google.com>
Tested-by: Maíra Canal <mairacanal@riseup.net>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
This commit is contained in:
David Gow 2022-07-01 16:47:43 +08:00 committed by Shuah Khan
parent 2852ca7fba
commit c272612cb4
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
include/kunit/test.h
View File

@ -277,7 +277,8 @@ static inline int kunit_run_all_tests(void)
{ \ { \
return __kunit_test_suites_exit(__suites); \ return __kunit_test_suites_exit(__suites); \
} \ } \
module_exit(kunit_test_suites_exit) module_exit(kunit_test_suites_exit) \
MODULE_INFO(test, "Y");
#else #else
#define kunit_test_suites_for_module(__suites) #define kunit_test_suites_for_module(__suites)
#endif /* MODULE */ #endif /* MODULE */

4
lib/kunit/test.c
View File

@ -11,6 +11,7 @@
#include <kunit/test-bug.h> #include <kunit/test-bug.h>
#include <linux/kernel.h> #include <linux/kernel.h>
#include <linux/moduleparam.h> #include <linux/moduleparam.h>
#include <linux/panic.h>
#include <linux/sched/debug.h> #include <linux/sched/debug.h>
#include <linux/sched.h> #include <linux/sched.h>
@ -501,6 +502,9 @@ int kunit_run_tests(struct kunit_suite *suite)
struct kunit_result_stats suite_stats = { 0 }; struct kunit_result_stats suite_stats = { 0 };
struct kunit_result_stats total_stats = { 0 }; struct kunit_result_stats total_stats = { 0 };
/* Taint the kernel so we know we've run tests. */
add_taint(TAINT_TEST, LOCKDEP_STILL_OK);
if (suite->suite_init) { if (suite->suite_init) {
suite->suite_init_err = suite->suite_init(suite); suite->suite_init_err = suite->suite_init(suite);
if (suite->suite_init_err) { if (suite->suite_init_err) {