leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sched/fair: Let minimally loaded cpu balance the group

Browse Source 
Currently we let the leftmost (or first idle) cpu ascend the
sched_domain tree and perform load-balancing. The result is that the
busiest cpu in the group might be performing this function and pull
more load to itself. The next load balance pass will then try to
equalize this again.

Change this to pick the least loaded cpu to perform higher domain
balancing.

Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/n/tip-v8zlrmgmkne3bkcy9dej1fvm@git.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
This commit is contained in:
Peter Zijlstra 2012-04-20 16:57:22 +02:00 committed by Ingo Molnar
parent c82513e513
commit c22402a2f7
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
kernel/sched/fair.c
View File

@ -3781,7 +3781,8 @@ static inline void update_sg_lb_stats(struct sched_domain *sd,
{ {
unsigned long load, max_cpu_load, min_cpu_load, max_nr_running; unsigned long load, max_cpu_load, min_cpu_load, max_nr_running;
int i; int i;
unsigned int balance_cpu = -1, first_idle_cpu = 0; unsigned int balance_cpu = -1;
unsigned long balance_load = ~0UL;
unsigned long avg_load_per_task = 0; unsigned long avg_load_per_task = 0;
if (local_group) if (local_group)
@ -3797,12 +3798,11 @@ static inline void update_sg_lb_stats(struct sched_domain *sd,
/* Bias balancing toward cpus of our domain */ /* Bias balancing toward cpus of our domain */
if (local_group) { if (local_group) {
if (idle_cpu(i) && !first_idle_cpu) { load = target_load(i, load_idx);
first_idle_cpu = 1; if (load < balance_load || idle_cpu(i)) {
balance_load = load;
balance_cpu = i; balance_cpu = i;
} }
load = target_load(i, load_idx);
} else { } else {
load = source_load(i, load_idx); load = source_load(i, load_idx);
if (load > max_cpu_load) { if (load > max_cpu_load) {