leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

posix_acl: don't ignore return value of posix_acl_create_masq()

Browse Source 
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Cc: Andreas Gruenbacher <agruenba@redhat.com>
This commit is contained in:
Miklos Szeredi 2016-09-16 12:44:21 +02:00
parent 280db3c88c
commit beaf226b86
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
fs/posix_acl.c
View File

@ -598,13 +598,14 @@ posix_acl_create(struct inode *dir, umode_t *mode,
if (IS_ERR(p)) if (IS_ERR(p))
return PTR_ERR(p); return PTR_ERR(p);
ret = -ENOMEM;
clone = posix_acl_clone(p, GFP_NOFS); clone = posix_acl_clone(p, GFP_NOFS);
if (!clone) if (!clone)
goto no_mem; goto err_release;
ret = posix_acl_create_masq(clone, mode); ret = posix_acl_create_masq(clone, mode);
if (ret < 0) if (ret < 0)
goto no_mem_clone; goto err_release_clone;
if (ret == 0) if (ret == 0)
posix_acl_release(clone); posix_acl_release(clone);
@ -618,11 +619,11 @@ posix_acl_create(struct inode *dir, umode_t *mode,
return 0; return 0;
no_mem_clone: err_release_clone:
posix_acl_release(clone); posix_acl_release(clone);
no_mem: err_release:
posix_acl_release(p); posix_acl_release(p);
return -ENOMEM; return ret;
} }
EXPORT_SYMBOL_GPL(posix_acl_create); EXPORT_SYMBOL_GPL(posix_acl_create);