leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drm/i915: Test all device memory on probing

Browse Source 
This extends the previous sanitychecking of device memory to read/write
all the memory on the device during the device probe, ala memtest86,
as an optional module parameter: i915.memtest=1. This is not expected to
be fast, but a reasonably thorough verfification that the device memory
is accessible and doesn't return bit errors.

v2: Rebased.

Suggested-by: Matthew Auld <matthew.auld@intel.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Matthew Auld <matthew.auld@intel.com>
Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20211208153404.27546-4-ramalingam.c@intel.com
This commit is contained in:
Chris Wilson
2021-12-08 21:04:04 +05:30
committed by Ramalingam C
parent 2e21de9028
commit bd56c63ca1
3 changed files with 28 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/gpu/drm/i915/i915_params.c
View File

@@ -140,6 +140,9 @@ i915_param_named_unsafe(invert_brightness, int, 0400,
i915_param_named(disable_display, bool, 0400, i915_param_named(disable_display, bool, 0400,
"Disable display (default: false)"); "Disable display (default: false)");
i915_param_named(memtest, bool, 0400,
"Perform a read/write test of all device memory on module load (default: off)");
i915_param_named(mmio_debug, int, 0400, i915_param_named(mmio_debug, int, 0400,
"Enable the MMIO debug code for the first N failures (default: off). " "Enable the MMIO debug code for the first N failures (default: off). "
"This may negatively affect performance."); "This may negatively affect performance.");

1
drivers/gpu/drm/i915/i915_params.h
View File

@@ -64,6 +64,7 @@ struct drm_printer;
param(char *, guc_firmware_path, NULL, 0400) \ param(char *, guc_firmware_path, NULL, 0400) \
param(char *, huc_firmware_path, NULL, 0400) \ param(char *, huc_firmware_path, NULL, 0400) \
param(char *, dmc_firmware_path, NULL, 0400) \ param(char *, dmc_firmware_path, NULL, 0400) \
param(bool, memtest, false, 0400) \
param(int, mmio_debug, -IS_ENABLED(CONFIG_DRM_I915_DEBUG_MMIO), 0600) \ param(int, mmio_debug, -IS_ENABLED(CONFIG_DRM_I915_DEBUG_MMIO), 0600) \
param(int, edp_vswing, 0, 0400) \ param(int, edp_vswing, 0, 0400) \
param(unsigned int, reset, 3, 0600) \ param(unsigned int, reset, 3, 0600) \

36
drivers/gpu/drm/i915/intel_memory_region.c
View File

@@ -93,9 +93,12 @@ static resource_size_t random_page(resource_size_t last)
return prandom_u32_max(last >> PAGE_SHIFT) << PAGE_SHIFT; return prandom_u32_max(last >> PAGE_SHIFT) << PAGE_SHIFT;
} }
static int iomemtest(struct intel_memory_region *mem, const void *caller) static int iomemtest(struct intel_memory_region *mem,
bool test_all,
const void *caller)
{ {
resource_size_t last = resource_size(&mem->region) - PAGE_SIZE; resource_size_t last = resource_size(&mem->region) - PAGE_SIZE;
resource_size_t page;
int err; int err;
/* /*
@@ -109,17 +112,25 @@ static int iomemtest(struct intel_memory_region *mem, const void *caller)
* a random offset within as a quick spot check for bad memory. * a random offset within as a quick spot check for bad memory.
*/ */
err = iopagetest(mem, 0, caller); if (test_all) {
if (err) for (page = 0; page <= last; page += PAGE_SIZE) {
return err; err = iopagetest(mem, page, caller);
if (err)
return err;
}
} else {
err = iopagetest(mem, 0, caller);
if (err)
return err;
err = iopagetest(mem, last, caller); err = iopagetest(mem, last, caller);
if (err) if (err)
return err; return err;
err = iopagetest(mem, random_page(last), caller); err = iopagetest(mem, random_page(last), caller);
if (err) if (err)
return err; return err;
}
return 0; return 0;
} }
@@ -188,13 +199,14 @@ void intel_memory_region_debug(struct intel_memory_region *mr,
static int intel_memory_region_memtest(struct intel_memory_region *mem, static int intel_memory_region_memtest(struct intel_memory_region *mem,
void *caller) void *caller)
{ {
struct drm_i915_private *i915 = mem->i915;
int err = 0; int err = 0;
if (!mem->io_start) if (!mem->io_start)
return 0; return 0;
if (IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM)) if (IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM) || i915->params.memtest)
err = iomemtest(mem, caller); err = iomemtest(mem, i915->params.memtest, caller);
return err; return err;
} }