leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[IPV6]: Lost locking in fl6_sock_lookup

Browse Source 
This routine scans the ipv6_fl_list whose update is
protected with the socket lock and the ip6_sk_fl_lock.

Since the socket lock is not taken in the lookup, use
the other one.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Pavel Emelyanov 2007-10-18 05:15:57 -07:00 committed by David S. Miller
parent 04028045a1
commit bd0bf57700
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
net/ipv6/ip6_flowlabel.c
View File

@ -190,14 +190,17 @@ struct ip6_flowlabel * fl6_sock_lookup(struct sock *sk, __be32 label)
label &= IPV6_FLOWLABEL_MASK; label &= IPV6_FLOWLABEL_MASK;
read_lock_bh(&ip6_sk_fl_lock);
for (sfl=np->ipv6_fl_list; sfl; sfl = sfl->next) { for (sfl=np->ipv6_fl_list; sfl; sfl = sfl->next) {
struct ip6_flowlabel *fl = sfl->fl; struct ip6_flowlabel *fl = sfl->fl;
if (fl->label == label) { if (fl->label == label) {
read_unlock_bh(&ip6_sk_fl_lock);
fl->lastuse = jiffies; fl->lastuse = jiffies;
atomic_inc(&fl->users); atomic_inc(&fl->users);
return fl; return fl;
} }
} }
read_unlock_bh(&ip6_sk_fl_lock);
return NULL; return NULL;
} }