leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

clocksource/drivers/timer-ti-dm: Switch to platform_get_irq

Browse Source 
platform_get_resource(pdev, IORESOURCE_IRQ) is not recommended for
requesting IRQ's resources, as they can be not ready yet. Using
platform_get_irq() instead is preferred for getting IRQ even if it
was not retrieved earlier.

Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20191221173027.30716-5-tiny.windzz@gmail.com
This commit is contained in:
Yangtao Li 2019-12-21 17:30:27 +00:00 committed by Daniel Lezcano
parent cdab83f9d0
commit bc83caddf1
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/clocksource/timer-ti-dm.c
View File

@ -780,7 +780,6 @@ static int omap_dm_timer_probe(struct platform_device *pdev)
{ {
unsigned long flags; unsigned long flags;
struct omap_dm_timer *timer; struct omap_dm_timer *timer;
struct resource *irq;
struct device *dev = &pdev->dev; struct device *dev = &pdev->dev;
const struct dmtimer_platform_data *pdata; const struct dmtimer_platform_data *pdata;
int ret; int ret;
@ -796,11 +795,9 @@ static int omap_dm_timer_probe(struct platform_device *pdev)
return -ENODEV; return -ENODEV;
} }
irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0); timer->irq = platform_get_irq(pdev, 0);
if (unlikely(!irq)) { if (timer->irq < 0)
dev_err(dev, "%s: no IRQ resource.\n", __func__); return timer->irq;
return -ENODEV;
}
timer = devm_kzalloc(dev, sizeof(*timer), GFP_KERNEL); timer = devm_kzalloc(dev, sizeof(*timer), GFP_KERNEL);
if (!timer) if (!timer)
@ -830,7 +827,6 @@ static int omap_dm_timer_probe(struct platform_device *pdev)
if (pdata) if (pdata)
timer->errata = pdata->timer_errata; timer->errata = pdata->timer_errata;
timer->irq = irq->start;
timer->pdev = pdev; timer->pdev = pdev;
pm_runtime_enable(dev); pm_runtime_enable(dev);