net: make ndo_get_stats64 a void function
The network device operation for reading statistics is only called in one place, and it ignores the return value. Having a structure return value is potentially confusing because some future driver could incorrectly assume that the return value was used. Fix all drivers with ndo_get_stats64 to have a void function. Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
committed by
David S. Miller
parent
63c64de7be
commit
bc1f44709c
@@ -2490,7 +2490,7 @@ static void dwceqos_read_mmc_counters(struct net_local *lp, u32 rx_mask,
|
||||
dwceqos_read(lp, DWC_MMC_RXPACKETCOUNT_GB);
|
||||
}
|
||||
|
||||
static struct rtnl_link_stats64*
|
||||
static void
|
||||
dwceqos_get_stats64(struct net_device *ndev, struct rtnl_link_stats64 *s)
|
||||
{
|
||||
unsigned long flags;
|
||||
@@ -2522,8 +2522,6 @@ dwceqos_get_stats64(struct net_device *ndev, struct rtnl_link_stats64 *s)
|
||||
else
|
||||
s->tx_errors = hwstats->txunderflowerror +
|
||||
hwstats->txcarriererror;
|
||||
|
||||
return s;
|
||||
}
|
||||
|
||||
static void
|
||||
|
||||
Reference in New Issue
Block a user