forked from Minki/linux
[POWERPC] Add missing of_node_put in pseries/nvram.c
of_node_put is needed before discarding a value received from of_find_node_by_type, eg in error handling code. The semantic patch that makes the change is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @@ struct device_node *n; struct device_node *n1; struct device_node *n2; statement S; identifier f1,f2; expression E1,E2; constant C; @@ n = of_find_node_by_type(...) ... if (!n) S ... when != of_node_put(n) when != n1 = f1(n,...) when != E1 = n when any when strict ( + of_node_put(n); return -C; | of_node_put(n); | n2 = f2(n,...) | E2 = n | return ...; ) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Acked-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Paul Mackerras <paulus@samba.org>
This commit is contained in:
parent
476ff8a0e3
commit
bad5232ba2
@ -131,8 +131,10 @@ int __init pSeries_nvram_init(void)
|
||||
return -ENODEV;
|
||||
|
||||
nbytes_p = of_get_property(nvram, "#bytes", &proplen);
|
||||
if (nbytes_p == NULL || proplen != sizeof(unsigned int))
|
||||
if (nbytes_p == NULL || proplen != sizeof(unsigned int)) {
|
||||
of_node_put(nvram);
|
||||
return -EIO;
|
||||
}
|
||||
|
||||
nvram_size = *nbytes_p;
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user