leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

platform/x86: intel_punit_ipc: use devm_platform_ioremap_resource() to simplify code

Browse Source 
Use devm_platform_ioremap_resource() to simplify the code a bit.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
This commit is contained in:
Andy Shevchenko 2019-10-21 12:24:43 +03:00
parent 16c6c05717
commit ba367730ff
1 changed files with 14 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
drivers/platform/x86/intel_punit_ipc.c
View File

@ -224,7 +224,6 @@ static irqreturn_t intel_punit_ioc(int irq, void *dev_id)
static int intel_punit_get_bars(struct platform_device *pdev) static int intel_punit_get_bars(struct platform_device *pdev)
{ {
struct resource *res;
void __iomem *addr; void __iomem *addr;
/* /*
@ -232,14 +231,12 @@ static int intel_punit_get_bars(struct platform_device *pdev)
* - BIOS_IPC BASE_DATA * - BIOS_IPC BASE_DATA
* - BIOS_IPC BASE_IFACE * - BIOS_IPC BASE_IFACE
*/ */
res = platform_get_resource(pdev, IORESOURCE_MEM, 0); addr = devm_platform_ioremap_resource(pdev, 0);
addr = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(addr)) if (IS_ERR(addr))
return PTR_ERR(addr); return PTR_ERR(addr);
punit_ipcdev->base[BIOS_IPC][BASE_DATA] = addr; punit_ipcdev->base[BIOS_IPC][BASE_DATA] = addr;
res = platform_get_resource(pdev, IORESOURCE_MEM, 1); addr = devm_platform_ioremap_resource(pdev, 1);
addr = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(addr)) if (IS_ERR(addr))
return PTR_ERR(addr); return PTR_ERR(addr);
punit_ipcdev->base[BIOS_IPC][BASE_IFACE] = addr; punit_ipcdev->base[BIOS_IPC][BASE_IFACE] = addr;
@ -251,33 +248,21 @@ static int intel_punit_get_bars(struct platform_device *pdev)
* - GTDRIVER_IPC BASE_DATA * - GTDRIVER_IPC BASE_DATA
* - GTDRIVER_IPC BASE_IFACE * - GTDRIVER_IPC BASE_IFACE
*/ */
res = platform_get_resource(pdev, IORESOURCE_MEM, 2); addr = devm_platform_ioremap_resource(pdev, 2);
if (res) { if (!IS_ERR(addr))
addr = devm_ioremap_resource(&pdev->dev, res); punit_ipcdev->base[ISPDRIVER_IPC][BASE_DATA] = addr;
if (!IS_ERR(addr))
punit_ipcdev->base[ISPDRIVER_IPC][BASE_DATA] = addr;
}
res = platform_get_resource(pdev, IORESOURCE_MEM, 3); addr = devm_platform_ioremap_resource(pdev, 3);
if (res) { if (!IS_ERR(addr))
addr = devm_ioremap_resource(&pdev->dev, res); punit_ipcdev->base[ISPDRIVER_IPC][BASE_IFACE] = addr;
if (!IS_ERR(addr))
punit_ipcdev->base[ISPDRIVER_IPC][BASE_IFACE] = addr;
}
res = platform_get_resource(pdev, IORESOURCE_MEM, 4); addr = devm_platform_ioremap_resource(pdev, 4);
if (res) { if (!IS_ERR(addr))
addr = devm_ioremap_resource(&pdev->dev, res); punit_ipcdev->base[GTDRIVER_IPC][BASE_DATA] = addr;
if (!IS_ERR(addr))
punit_ipcdev->base[GTDRIVER_IPC][BASE_DATA] = addr;
}
res = platform_get_resource(pdev, IORESOURCE_MEM, 5); addr = devm_platform_ioremap_resource(pdev, 5);
if (res) { if (!IS_ERR(addr))
addr = devm_ioremap_resource(&pdev->dev, res); punit_ipcdev->base[GTDRIVER_IPC][BASE_IFACE] = addr;
if (!IS_ERR(addr))
punit_ipcdev->base[GTDRIVER_IPC][BASE_IFACE] = addr;
}
return 0; return 0;
} }