leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

perf tools: Don't stop synthesizing threads when one vanishes

Browse Source 
The perf_event__synthesize_threads routine synthesizes all the existing
threads in the system, because we don't have any kernel facilities to
ask for PERF_RECORD_{FORK,MMAP,COMM} for existing threads.

It was returning an error as soon as one thread couldn't be synthesized,
which is a bit extreme when, for instance, a forkish workload is
running, like a kernel compile.

Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-i7oas1eodpoer2bx38fwyasv@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Arnaldo Carvalho de Melo
2012-10-17 18:50:13 -03:00
parent 6ca2a9c654
commit ba361c92e7
1 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
tools/perf/util/event.c
View File

@@ -405,16 +405,15 @@ int perf_event__synthesize_threads(struct perf_tool *tool,
if (*end) /* only interested in proper numerical dirents */ if (*end) /* only interested in proper numerical dirents */
continue; continue;
/*
if (__event__synthesize_thread(comm_event, mmap_event, pid, 1, * We may race with exiting thread, so don't stop just because
process, tool, machine) != 0) { * one thread couldn't be synthesized.
err = -1; */
goto out_closedir; __event__synthesize_thread(comm_event, mmap_event, pid, 1,
} process, tool, machine);
} }
err = 0; err = 0;
out_closedir:
closedir(proc); closedir(proc);
out_free_mmap: out_free_mmap:
free(mmap_event); free(mmap_event);