leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mtd: spinand: read returns badly if the last page has bitflips

Browse Source 
In case of the last page containing bitflips (ret > 0),
spinand_mtd_read() will return that number of bitflips for the last
page while it should instead return max_bitflips like it does when the
last page read returns with 0.

Signed-off-by: Weixiong Liao <liaoweixiong@allwinnertech.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Cc: stable@vger.kernel.org
Fixes: 7529df4652 ("mtd: nand: Add core infrastructure to support SPI NANDs")
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
This commit is contained in:
liaoweixiong 2019-06-28 12:14:46 +08:00 committed by Miquel Raynal
parent 3552691616
commit b83408b580
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/mtd/nand/spi/core.c
View File

@ -511,12 +511,12 @@ static int spinand_mtd_read(struct mtd_info *mtd, loff_t from,
if (ret == -EBADMSG) { if (ret == -EBADMSG) {
ecc_failed = true; ecc_failed = true;
mtd->ecc_stats.failed++; mtd->ecc_stats.failed++;
ret = 0;
} else { } else {
mtd->ecc_stats.corrected += ret; mtd->ecc_stats.corrected += ret;
max_bitflips = max_t(unsigned int, max_bitflips, ret); max_bitflips = max_t(unsigned int, max_bitflips, ret);
} }
ret = 0;
ops->retlen += iter.req.datalen; ops->retlen += iter.req.datalen;
ops->oobretlen += iter.req.ooblen; ops->oobretlen += iter.req.ooblen;
} }