genirq: Warn when handler enables interrupts
We run all handlers with interrupts disabled and expect them not to enable them. Warn when we catch one who does. Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
This commit is contained in:
		
							parent
							
								
									1082687e8d
								
							
						
					
					
						commit
						b738a50a20
					
				| @ -68,6 +68,9 @@ irqreturn_t handle_IRQ_event(unsigned int irq, struct irqaction *action) | |||||||
| 		ret = action->handler(irq, action->dev_id); | 		ret = action->handler(irq, action->dev_id); | ||||||
| 		trace_irq_handler_exit(irq, action, ret); | 		trace_irq_handler_exit(irq, action, ret); | ||||||
| 
 | 
 | ||||||
|  | 		if (WARN_ON_ONCE(!irqs_disabled())) | ||||||
|  | 			local_irq_disable(); | ||||||
|  | 
 | ||||||
| 		switch (ret) { | 		switch (ret) { | ||||||
| 		case IRQ_WAKE_THREAD: | 		case IRQ_WAKE_THREAD: | ||||||
| 			/*
 | 			/*
 | ||||||
| @ -114,7 +117,6 @@ irqreturn_t handle_IRQ_event(unsigned int irq, struct irqaction *action) | |||||||
| 
 | 
 | ||||||
| 	if (status & IRQF_SAMPLE_RANDOM) | 	if (status & IRQF_SAMPLE_RANDOM) | ||||||
| 		add_interrupt_randomness(irq); | 		add_interrupt_randomness(irq); | ||||||
| 	local_irq_disable(); |  | ||||||
| 
 | 
 | ||||||
| 	return retval; | 	return retval; | ||||||
| } | } | ||||||
|  | |||||||
		Loading…
	
		Reference in New Issue
	
	Block a user