leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

af_rxrpc: Prevent RxRPC peers from ABORT-storming one another

Browse Source 
When an ABORT is sent, aborting a connection, the sender quite reasonably
forgets about the connection.  If another frame is received, another ABORT
will be sent.  When the receiver gets it, it no longer applies to an extant
connection, so an ABORT is sent, and so on...

Prevent this by never sending a rejection for an ABORT packet.

Signed-off-by: Tim Smith <tim@electronghost.co.uk>
Signed-off-by: David Howells <dhowells@redhat.com>
This commit is contained in:
Tim Smith 2014-02-07 18:58:43 +00:00 committed by David Howells
parent 8961749e5f
commit b6f3a40cb7
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
net/rxrpc/ar-input.c
View File

@ -606,8 +606,10 @@ dead_call:
}
_debug("dead call");
skb->priority = RX_CALL_DEAD;
rxrpc_reject_packet(conn->trans->local, skb);
if (sp->hdr.type != RXRPC_PACKET_TYPE_ABORT) {
skb->priority = RX_CALL_DEAD;
rxrpc_reject_packet(conn->trans->local, skb);
}
goto done;
/* resend last packet of a completed call
@ -790,8 +792,10 @@ cant_route_call:
skb->priority = RX_CALL_DEAD;
}
_debug("reject");
rxrpc_reject_packet(local, skb);
if (sp->hdr.type != RXRPC_PACKET_TYPE_ABORT) {
_debug("reject type %d",sp->hdr.type);
rxrpc_reject_packet(local, skb);
}
rxrpc_put_local(local);
_leave(" [no call]");
return;