leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

be2net: use GET_MAC_LIST cmd to query mac-address from a pmac-id

Browse Source 
The use of NTKW_MAC_QUERY cmd has been deprecated for Skyhawk-R.
Replace the last remaining usage in be_vfs_mac_query() routine.

Signed-off-by: Suresh Reddy <suresh.reddy@emulex.com>
Signed-off-by: Sathya Perla <sathya.perla@emulex.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Suresh Reddy 2014-01-15 13:23:39 +05:30 committed by David S. Miller
parent 0b0ef1d027
commit b188f0907a
3 changed files with 23 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
drivers/net/ethernet/emulex/benet/be_cmds.c
View File

@ -2742,7 +2742,8 @@ err:
* If pmac_id is returned, pmac_id_valid is returned as true * If pmac_id is returned, pmac_id_valid is returned as true
*/ */
int be_cmd_get_mac_from_list(struct be_adapter *adapter, u8 *mac, int be_cmd_get_mac_from_list(struct be_adapter *adapter, u8 *mac,
bool *pmac_id_valid, u32 *pmac_id, u8 domain) bool *pmac_id_valid, u32 *pmac_id, u32 if_handle,
u8 domain)
{ {
struct be_mcc_wrb *wrb; struct be_mcc_wrb *wrb;
struct be_cmd_req_get_mac_list *req; struct be_cmd_req_get_mac_list *req;
@ -2780,7 +2781,7 @@ int be_cmd_get_mac_from_list(struct be_adapter *adapter, u8 *mac,
req->mac_type = MAC_ADDRESS_TYPE_NETWORK; req->mac_type = MAC_ADDRESS_TYPE_NETWORK;
if (*pmac_id_valid) { if (*pmac_id_valid) {
req->mac_id = cpu_to_le32(*pmac_id); req->mac_id = cpu_to_le32(*pmac_id);
req->iface_id = cpu_to_le16(adapter->if_handle); req->iface_id = cpu_to_le16(if_handle);
req->perm_override = 0; req->perm_override = 0;
} else { } else {
req->perm_override = 1; req->perm_override = 1;
@ -2833,17 +2834,21 @@ out:
return status; return status;
} }
int be_cmd_get_active_mac(struct be_adapter *adapter, u32 curr_pmac_id, u8 *mac) int be_cmd_get_active_mac(struct be_adapter *adapter, u32 curr_pmac_id, u8 *mac,
u32 if_handle, bool active, u32 domain)
{ {
bool active = true;
if (!active)
be_cmd_get_mac_from_list(adapter, mac, &active, &curr_pmac_id,
if_handle, domain);
if (BEx_chip(adapter)) if (BEx_chip(adapter))
return be_cmd_mac_addr_query(adapter, mac, false, return be_cmd_mac_addr_query(adapter, mac, false,
adapter->if_handle, curr_pmac_id); if_handle, curr_pmac_id);
else else
/* Fetch the MAC address using pmac_id */ /* Fetch the MAC address using pmac_id */
return be_cmd_get_mac_from_list(adapter, mac, &active, return be_cmd_get_mac_from_list(adapter, mac, &active,
&curr_pmac_id, 0); &curr_pmac_id,
if_handle, domain);
} }
int be_cmd_get_perm_mac(struct be_adapter *adapter, u8 *mac) int be_cmd_get_perm_mac(struct be_adapter *adapter, u8 *mac)
@ -2862,7 +2867,7 @@ int be_cmd_get_perm_mac(struct be_adapter *adapter, u8 *mac)
adapter->if_handle, 0); adapter->if_handle, 0);
} else { } else {
status = be_cmd_get_mac_from_list(adapter, mac, &pmac_valid, status = be_cmd_get_mac_from_list(adapter, mac, &pmac_valid,
NULL, 0); NULL, adapter->if_handle, 0);
} }
return status; return status;
@ -2923,7 +2928,8 @@ int be_cmd_set_mac(struct be_adapter *adapter, u8 *mac, int if_id, u32 dom)
int status; int status;
status = be_cmd_get_mac_from_list(adapter, old_mac, &active_mac, status = be_cmd_get_mac_from_list(adapter, old_mac, &active_mac,
&pmac_id, dom); &pmac_id, if_id, dom);
if (!status && active_mac) if (!status && active_mac)
be_cmd_pmac_del(adapter, if_id, pmac_id, dom); be_cmd_pmac_del(adapter, if_id, pmac_id, dom);

6
drivers/net/ethernet/emulex/benet/be_cmds.h
View File

@ -2057,8 +2057,10 @@ int be_cmd_get_fn_privileges(struct be_adapter *adapter, u32 *privilege,
int be_cmd_set_fn_privileges(struct be_adapter *adapter, u32 privileges, int be_cmd_set_fn_privileges(struct be_adapter *adapter, u32 privileges,
u32 vf_num); u32 vf_num);
int be_cmd_get_mac_from_list(struct be_adapter *adapter, u8 *mac, int be_cmd_get_mac_from_list(struct be_adapter *adapter, u8 *mac,
bool *pmac_id_active, u32 *pmac_id, u8 domain); bool *pmac_id_active, u32 *pmac_id,
int be_cmd_get_active_mac(struct be_adapter *adapter, u32 pmac_id, u8 *mac); u32 if_handle, u8 domain);
int be_cmd_get_active_mac(struct be_adapter *adapter, u32 pmac_id, u8 *mac,
u32 if_handle, bool active, u32 domain);
int be_cmd_get_perm_mac(struct be_adapter *adapter, u8 *mac); int be_cmd_get_perm_mac(struct be_adapter *adapter, u8 *mac);
int be_cmd_set_mac_list(struct be_adapter *adapter, u8 *mac_array, u8 mac_count, int be_cmd_set_mac_list(struct be_adapter *adapter, u8 *mac_array, u8 mac_count,
u32 domain); u32 domain);

12
drivers/net/ethernet/emulex/benet/be_main.c
View File

@ -280,7 +280,8 @@ static int be_mac_addr_set(struct net_device *netdev, void *p)
/* Decide if the new MAC is successfully activated only after /* Decide if the new MAC is successfully activated only after
* querying the FW * querying the FW
*/ */
status = be_cmd_get_active_mac(adapter, curr_pmac_id, mac); status = be_cmd_get_active_mac(adapter, curr_pmac_id, mac,
adapter->if_handle, true, 0);
if (status) if (status)
goto err; goto err;
@ -2872,14 +2873,11 @@ static int be_vfs_mac_query(struct be_adapter *adapter)
int status, vf; int status, vf;
u8 mac[ETH_ALEN]; u8 mac[ETH_ALEN];
struct be_vf_cfg *vf_cfg; struct be_vf_cfg *vf_cfg;
bool active = false;
for_all_vfs(adapter, vf_cfg, vf) { for_all_vfs(adapter, vf_cfg, vf) {
be_cmd_get_mac_from_list(adapter, mac, &active, status = be_cmd_get_active_mac(adapter, vf_cfg->pmac_id,
&vf_cfg->pmac_id, 0); mac, vf_cfg->if_handle,
false, vf+1);
status = be_cmd_mac_addr_query(adapter, mac, false,
vf_cfg->if_handle, 0);
if (status) if (status)
return status; return status;
memcpy(vf_cfg->mac_addr, mac, ETH_ALEN); memcpy(vf_cfg->mac_addr, mac, ETH_ALEN);