leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

smp: Move irq_work_run() out of flush_smp_call_function_queue()

Browse Source 
This ensures flush_smp_call_function_queue() is strictly about
call_single_queue.

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20200526161907.895109676@infradead.org
This commit is contained in:
Peter Zijlstra 2020-05-26 18:11:00 +02:00 committed by Ingo Molnar
parent 52103be07d
commit afaa653c56
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
kernel/smp.c
View File

@ -84,6 +84,7 @@ int smpcfd_dying_cpu(unsigned int cpu)
* still pending. * still pending.
*/ */
flush_smp_call_function_queue(false); flush_smp_call_function_queue(false);
irq_work_run();
return 0; return 0;
} }
@ -191,6 +192,14 @@ static int generic_exec_single(int cpu, call_single_data_t *csd,
void generic_smp_call_function_single_interrupt(void) void generic_smp_call_function_single_interrupt(void)
{ {
flush_smp_call_function_queue(true); flush_smp_call_function_queue(true);
/*
* Handle irq works queued remotely by irq_work_queue_on().
* Smp functions above are typically synchronous so they
* better run first since some other CPUs may be busy waiting
* for them.
*/
irq_work_run();
} }
/** /**
@ -267,14 +276,6 @@ static void flush_smp_call_function_queue(bool warn_cpu_offline)
csd_unlock(csd); csd_unlock(csd);
func(info); func(info);
} }
/*
* Handle irq works queued remotely by irq_work_queue_on().
* Smp functions above are typically synchronous so they
* better run first since some other CPUs may be busy waiting
* for them.
*/
irq_work_run();
} }
/* /*