leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bnx2x: allocate memory dynamically in ethtool self-test.

Browse Source 
From: Merav Sicron <meravs@broadcom.com>

Current ethtool self tests usesa large buffer on stack. This patch replaces
that array by dynamically allocated memory

Signed-off-by: Merav Sicron <meravs@broadcom.com>
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Mintz Yuval 2012-02-15 02:10:27 +00:00 committed by David S. Miller
parent 817a8aa8cf
commit afa13b4b94
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c
View File

@ -2016,14 +2016,22 @@ static int bnx2x_test_nvram(struct bnx2x *bp)
{ 0x708, 0x70 }, /* manuf_key_info */ { 0x708, 0x70 }, /* manuf_key_info */
{ 0, 0 } { 0, 0 }
}; };
__be32 buf[0x350 / 4]; __be32 *buf;
u8 *data = (u8 *)buf; u8 *data;
int i, rc; int i, rc;
u32 magic, crc; u32 magic, crc;
if (BP_NOMCP(bp)) if (BP_NOMCP(bp))
return 0; return 0;
buf = kmalloc(0x350, GFP_KERNEL);
if (!buf) {
DP(NETIF_MSG_PROBE, "kmalloc failed\n");
rc = -ENOMEM;
goto test_nvram_exit;
}
data = (u8 *)buf;
rc = bnx2x_nvram_read(bp, 0, data, 4); rc = bnx2x_nvram_read(bp, 0, data, 4);
if (rc) { if (rc) {
DP(NETIF_MSG_PROBE, "magic value read (rc %d)\n", rc); DP(NETIF_MSG_PROBE, "magic value read (rc %d)\n", rc);
@ -2057,6 +2065,7 @@ static int bnx2x_test_nvram(struct bnx2x *bp)
} }
test_nvram_exit: test_nvram_exit:
kfree(buf);
return rc; return rc;
} }