forked from Minki/linux
fs/reiserfs/super.c: correct use of ! and &
In commit e6bafba5b4
("wmi: (!x & y)
strikes again"), a bug was fixed that involved converting !x & y to !(x
& y). The code below shows the same pattern, and thus should perhaps be
fixed in the same way.
This is not tested and clearly changes the semantics, so it is only
something to consider.
The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@ expression E1,E2; @@
(
!E1 & !E2
|
- !E1 & E2
+ !(E1 & E2)
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Chris Mason <chris.mason@oracle.com>
Cc: Jeff Mahoney <jeffm@suse.com>
Cc: Jan Kara <jack@ucw.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
parent
022d917d96
commit
acc1f3ede9
@ -2031,7 +2031,7 @@ static int reiserfs_quota_on(struct super_block *sb, int type, int format_id,
|
||||
return -EXDEV;
|
||||
}
|
||||
/* We must not pack tails for quota files on reiserfs for quota IO to work */
|
||||
if (!REISERFS_I(nd.path.dentry->d_inode)->i_flags & i_nopack_mask) {
|
||||
if (!(REISERFS_I(nd.path.dentry->d_inode)->i_flags & i_nopack_mask)) {
|
||||
reiserfs_warning(sb,
|
||||
"reiserfs: Quota file must have tail packing disabled.");
|
||||
path_put(&nd.path);
|
||||
|
Loading…
Reference in New Issue
Block a user