leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drm/amd: cleanup get_mfd_cell_dev()

Browse Source 
It's simpler to just use snprintf() to print this to one buffer instead
of using strcpy() and strcat().  Also using snprintf() is slightly safer
than using sprintf().

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
This commit is contained in:
Dan Carpenter
2016-02-25 10:47:10 +03:00
committed by Alex Deucher
parent 70eacc72db
commit a65ecc4070
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c
View File

@@ -240,12 +240,10 @@ static int acp_poweron(struct generic_pm_domain *genpd)
static struct device *get_mfd_cell_dev(const char *device_name, int r) static struct device *get_mfd_cell_dev(const char *device_name, int r)
{ {
char auto_dev_name[25]; char auto_dev_name[25];
char buf[8];
struct device *dev; struct device *dev;
sprintf(buf, ".%d.auto", r); snprintf(auto_dev_name, sizeof(auto_dev_name),
strcpy(auto_dev_name, device_name); "%s.%d.auto", device_name, r);
strcat(auto_dev_name, buf);
dev = bus_find_device_by_name(&platform_bus_type, NULL, auto_dev_name); dev = bus_find_device_by_name(&platform_bus_type, NULL, auto_dev_name);
dev_info(dev, "device %s added to pm domain\n", auto_dev_name); dev_info(dev, "device %s added to pm domain\n", auto_dev_name);