leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

staging: dgnc: clean up the dgnc_get_modem_info()

Browse Source 
the "ch" in dgnc_get_modem_info() was already checked before calling
this function and also if "ch" is not NULL, dgnc_get_mstat() returns
valid value so it doesn't need to check an error.

Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Daeseok Youn 2016-05-04 14:13:48 +09:00 committed by Greg Kroah-Hartman
parent 1b30ccded5
commit a5b90ef7a1
1 changed files with 1 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/staging/dgnc/dgnc_tty.c
View File

@ -2020,17 +2020,7 @@ static inline int dgnc_get_mstat(struct channel_t *ch)
static int dgnc_get_modem_info(struct channel_t *ch,
unsigned int __user *value)
{
int result;
if (!ch || ch->magic != DGNC_CHANNEL_MAGIC)
return -ENXIO;
result = dgnc_get_mstat(ch);
if (result < 0)
return -ENXIO;
return put_user(result, value);
return put_user(dgnc_get_mstat(ch), value);
}
/*