leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ipwireless: fix potential tty == NULL dereference

Browse Source 
The Coverity checker spotted the following inconsequent NULL checking in
drivers/char/pcmcia/ipwireless/network.c:ipwireless_network_packet_received()

if (tty && channel_idx == IPW_CHANNEL_RAS
		&& (network->ras_control_lines &
			IPW_CONTROL_LINE_DCD) != 0
		&& ipwireless_tty_is_modem(tty)) {
...
	else
		ipwireless_tty_received(tty, data, length);

Cc: Adrian Bunk <bunk@kernel.org>
Signed-off-by: David Sterba <dsterba@suse.cz>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Cc: "John W. Linville" <linville@tuxdriver.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
David Sterba 2008-03-04 14:28:50 -08:00 committed by Linus Torvalds
parent 3149be50d3
commit a51f4124e6
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/char/pcmcia/ipwireless/network.c
View File

@ -377,13 +377,16 @@ void ipwireless_network_packet_received(struct ipw_network *network,
for (i = 0; i < MAX_ASSOCIATED_TTYS; i++) { for (i = 0; i < MAX_ASSOCIATED_TTYS; i++) {
struct ipw_tty *tty = network->associated_ttys[channel_idx][i]; struct ipw_tty *tty = network->associated_ttys[channel_idx][i];
if (!tty)
continue;
/* /*
* If it's associated with a tty (other than the RAS channel * If it's associated with a tty (other than the RAS channel
* when we're online), then send the data to that tty. The RAS * when we're online), then send the data to that tty. The RAS
* channel's data is handled above - it always goes through * channel's data is handled above - it always goes through
* ppp_generic. * ppp_generic.
*/ */
if (tty && channel_idx == IPW_CHANNEL_RAS if (channel_idx == IPW_CHANNEL_RAS
&& (network->ras_control_lines & && (network->ras_control_lines &
IPW_CONTROL_LINE_DCD) != 0 IPW_CONTROL_LINE_DCD) != 0
&& ipwireless_tty_is_modem(tty)) { && ipwireless_tty_is_modem(tty)) {