leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

reiserfs: fix hang on umount with quotas when journal is aborted

Browse Source 
Call dquot_drop() from reiserfs_dquot_drop() even if we fail to start a
transaction.  Otherwise we never get to dropping references to quota
structures from the inode and umount will hang indefinitely.

Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Jan Kara 2008-04-28 02:16:23 -07:00 committed by Linus Torvalds
parent fbe5498b3d
commit a2fe594fa3
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
fs/reiserfs/super.c
View File

@ -1890,8 +1890,14 @@ static int reiserfs_dquot_drop(struct inode *inode)
ret = ret =
journal_begin(&th, inode->i_sb, journal_begin(&th, inode->i_sb,
2 * REISERFS_QUOTA_DEL_BLOCKS(inode->i_sb)); 2 * REISERFS_QUOTA_DEL_BLOCKS(inode->i_sb));
if (ret) if (ret) {
/*
* We call dquot_drop() anyway to at least release references
* to quota structures so that umount does not hang.
*/
dquot_drop(inode);
goto out; goto out;
}
ret = dquot_drop(inode); ret = dquot_drop(inode);
err = err =
journal_end(&th, inode->i_sb, journal_end(&th, inode->i_sb,