leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

w1: fix for loop exit condition in w1_seq_show()

Browse Source 
The W1_42_FINISHED_BYTE is 0xFF so the cast means the condition is
never true.

Fixes: d9411e57dc ('w1: Add support for DS28EA00 sequence to w1-therm')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Dan Carpenter 2015-06-01 12:55:37 +03:00 committed by Greg Kroah-Hartman
parent fc368ea1ea
commit a14ef24b07
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/w1/slaves/w1_therm.c
View File

@ -378,7 +378,7 @@ static ssize_t w1_seq_show(struct device *device,
w1_write_8(sl->master, W1_42_COND_READ); w1_write_8(sl->master, W1_42_COND_READ);
rv = w1_read_block(sl->master, (u8 *)&rn, 8); rv = w1_read_block(sl->master, (u8 *)&rn, 8);
reg_num = (struct w1_reg_num *) &rn; reg_num = (struct w1_reg_num *) &rn;
if ((char)reg_num->family == W1_42_FINISHED_BYTE) if (reg_num->family == W1_42_FINISHED_BYTE)
break; break;
if (sl->reg_num.id == reg_num->id) if (sl->reg_num.id == reg_num->id)
seq = i; seq = i;