leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lightnvm: Inherit mdts from the parent nvme device

Browse Source 
Current lightnvm and pblk implementation does not care about NVMe max
data transfer size, which can be smaller than 64*K=256K. There are
existing NVMe controllers which NVMe max data transfer size is lower
that 256K (for example 128K, which happens for existing NVMe
controllers which are NVMe spec compliant). Such a controllers are not
able to handle command which contains 64 PPAs, since the the size of
DMAed buffer will be above the capabilities of such a controller.

Signed-off-by: Igor Konopko <igor.j.konopko@intel.com>
Reviewed-by: Hans Holmberg <hans.holmberg@cnexlabs.com>
Reviewed-by: Javier González <javier@javigon.com>
Signed-off-by: Matias Bjørling <mb@lightnvm.io>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Igor Konopko 2019-05-04 20:37:55 +02:00 committed by Jens Axboe
parent d38954ed1b
commit a14669ebc0
3 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/lightnvm/core.c
View File

@ -325,6 +325,7 @@ static int nvm_create_tgt(struct nvm_dev *dev, struct nvm_ioctl_create *create)
struct nvm_target *t; struct nvm_target *t;
struct nvm_tgt_dev *tgt_dev; struct nvm_tgt_dev *tgt_dev;
void *targetdata; void *targetdata;
unsigned int mdts;
int ret; int ret;
switch (create->conf.type) { switch (create->conf.type) {
@ -412,8 +413,12 @@ static int nvm_create_tgt(struct nvm_dev *dev, struct nvm_ioctl_create *create)
tdisk->private_data = targetdata; tdisk->private_data = targetdata;
tqueue->queuedata = targetdata; tqueue->queuedata = targetdata;
blk_queue_max_hw_sectors(tqueue, mdts = (dev->geo.csecs >> 9) * NVM_MAX_VLBA;
(dev->geo.csecs >> 9) * NVM_MAX_VLBA); if (dev->geo.mdts) {
mdts = min_t(u32, dev->geo.mdts,
(dev->geo.csecs >> 9) * NVM_MAX_VLBA);
}
blk_queue_max_hw_sectors(tqueue, mdts);
set_capacity(tdisk, tt->capacity(targetdata)); set_capacity(tdisk, tt->capacity(targetdata));
add_disk(tdisk); add_disk(tdisk);

1
drivers/nvme/host/lightnvm.c
View File

@ -977,6 +977,7 @@ int nvme_nvm_register(struct nvme_ns *ns, char *disk_name, int node)
geo->csecs = 1 << ns->lba_shift; geo->csecs = 1 << ns->lba_shift;
geo->sos = ns->ms; geo->sos = ns->ms;
geo->ext = ns->ext; geo->ext = ns->ext;
geo->mdts = ns->ctrl->max_hw_sectors;
dev->q = q; dev->q = q;
memcpy(dev->name, disk_name, DISK_NAME_LEN); memcpy(dev->name, disk_name, DISK_NAME_LEN);

1
include/linux/lightnvm.h
View File

@ -358,6 +358,7 @@ struct nvm_geo {
u16 csecs; /* sector size */ u16 csecs; /* sector size */
u16 sos; /* out-of-band area size */ u16 sos; /* out-of-band area size */
bool ext; /* metadata in extended data buffer */ bool ext; /* metadata in extended data buffer */
u32 mdts; /* Max data transfer size*/
/* device write constrains */ /* device write constrains */
u32 ws_min; /* minimum write size */ u32 ws_min; /* minimum write size */