leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

checkpatch: add warning on BUG/BUG_ON use

Browse Source 
Using BUG/BUG_ON crashes the kernel and is just unfriendly.

Enable code that emits a warning on BUG/BUG_ON use.

Make the code emit the message at WARNING level when scanning a patch and
at CHECK level when scanning files so that script users don't feel an
obligation to fix code that might be above their pay grade.

Signed-off-by: Joe Perches <joe@perches.com>
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Tested-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Joe Perches 2015-09-09 15:37:27 -07:00 committed by Linus Torvalds
parent fe043ea120
commit 9d3e3c705e
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
scripts/checkpatch.pl
View File

@ -3448,13 +3448,15 @@ sub process {
} }
} }
# # no BUG() or BUG_ON() # avoid BUG() or BUG_ON()
# if ($line =~ /\b(BUG|BUG_ON)\b/) { if ($line =~ /\b(?:BUG|BUG_ON)\b/) {
# print "Try to use WARN_ON & Recovery code rather than BUG() or BUG_ON()\n"; my $msg_type = \&WARN;
# print "$herecurr"; $msg_type = \&CHK if ($file);
# $clean = 0; &{$msg_type}("AVOID_BUG",
# } "Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()\n" . $herecurr);
}
# avoid LINUX_VERSION_CODE
if ($line =~ /\bLINUX_VERSION_CODE\b/) { if ($line =~ /\bLINUX_VERSION_CODE\b/) {
WARN("LINUX_VERSION_CODE", WARN("LINUX_VERSION_CODE",
"LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged\n" . $herecurr); "LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged\n" . $herecurr);