leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

xen/privcmd: return -EFAULT on error

Browse Source 
__copy_to_user() returns the number of bytes remaining to be copied but
we want to return a negative error code here.

Acked-by: Andres Lagar-Cavilla <andres@lagarcavilla.org>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
This commit is contained in:
Dan Carpenter 2012-09-08 12:57:35 +03:00 committed by Konrad Rzeszutek Wilk
parent 1714df7f2c
commit 9d2be92871
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/xen/privcmd.c
View File

@ -389,8 +389,11 @@ static long privcmd_ioctl_mmap_batch(void __user *udata, int version)
state.err = err_array; state.err = err_array;
ret = traverse_pages(m.num, sizeof(xen_pfn_t), ret = traverse_pages(m.num, sizeof(xen_pfn_t),
&pagelist, mmap_return_errors_v1, &state); &pagelist, mmap_return_errors_v1, &state);
} else if (version == 2) } else if (version == 2) {
ret = __copy_to_user(m.err, err_array, m.num * sizeof(int)); ret = __copy_to_user(m.err, err_array, m.num * sizeof(int));
if (ret)
ret = -EFAULT;
}
/* If we have not had any EFAULT-like global errors then set the global /* If we have not had any EFAULT-like global errors then set the global
* error to -ENOENT if necessary. */ * error to -ENOENT if necessary. */