leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

NFS: Only look at the change attribute cache state in nfs_weak_revalidate()

Browse Source 
Just like in nfs_check_verifier(), we want to use
nfs_mapping_need_revalidate_inode() to check our knowledge of the
change attribute is up to date.

Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
This commit is contained in:
Trond Myklebust 2016-12-16 18:04:47 -05:00
parent 61540bf6bb
commit 9cdd1d3f1a
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
fs/nfs/dir.c
View File

@ -1273,8 +1273,8 @@ out_error:
*/ */
static int nfs_weak_revalidate(struct dentry *dentry, unsigned int flags) static int nfs_weak_revalidate(struct dentry *dentry, unsigned int flags)
{ {
int error;
struct inode *inode = d_inode(dentry); struct inode *inode = d_inode(dentry);
int error = 0;
/* /*
* I believe we can only get a negative dentry here in the case of a * I believe we can only get a negative dentry here in the case of a
@ -1293,7 +1293,8 @@ static int nfs_weak_revalidate(struct dentry *dentry, unsigned int flags)
return 0; return 0;
} }
error = nfs_revalidate_inode(NFS_SERVER(inode), inode); if (nfs_mapping_need_revalidate_inode(inode))
error = __nfs_revalidate_inode(NFS_SERVER(inode), inode);
dfprintk(LOOKUPCACHE, "NFS: %s: inode %lu is %s\n", dfprintk(LOOKUPCACHE, "NFS: %s: inode %lu is %s\n",
__func__, inode->i_ino, error ? "invalid" : "valid"); __func__, inode->i_ino, error ? "invalid" : "valid");
return !error; return !error;