leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[PATCH] splice: potential !page dereference

Browse Source 
We can get to out: with a NULL page, which we probably
don't want to be calling page_cache_release() on.

Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Jens Axboe <axboe@suse.de>
This commit is contained in:
Dave Jones 2006-04-10 09:02:40 +02:00 committed by Jens Axboe
parent c7f21e4f5a
commit 9aefe431f5
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
fs/splice.c
View File

@ -445,7 +445,7 @@ find_page:
ret = -ENOMEM;
page = find_or_create_page(mapping, index, gfp_mask);
if (!page)
goto out;
goto out_nomem;
/*
* If the page is uptodate, it is also locked. If it isn't
@ -508,6 +508,7 @@ out:
page_cache_release(page);
unlock_page(page);
}
out_nomem:
buf->ops->unmap(info, buf);
return ret;
}