leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ALSA: Limit the fallback card id string size

Browse Source 
When no proper id string is given, the driver tries to fall back to
copy the proc_root name string via strcpy(), but this might overflow
the fixed string size.  Let's use strlcpy().

Spotted by coverity CID 139008.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Takashi Iwai 2013-10-29 15:20:06 +01:00
parent 75415df8ff
commit 97f44f56ca
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sound/core/init.c
View File

@ -597,7 +597,7 @@ static void snd_card_set_id_no_lock(struct snd_card *card, const char *src,
/* last resort... */ /* last resort... */
snd_printk(KERN_ERR "unable to set card id (%s)\n", id); snd_printk(KERN_ERR "unable to set card id (%s)\n", id);
if (card->proc_root->name) if (card->proc_root->name)
strcpy(card->id, card->proc_root->name); strlcpy(card->id, card->proc_root->name, sizeof(card->id));
} }
/** /**