leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

perf hists: Introduce hists__scnprint_title()

Browse Source 
That is not use any struct hists_browser internals, so that it can be
shared with the other UIs and tools.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Martin Liška <mliska@suse.cz>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=196935
Link: https://lkml.kernel.org/n/tip-w8mczjnqnbcj9yzfkv9ja6ro@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Arnaldo Carvalho de Melo
2018-04-02 14:20:20 -03:00
parent f016d24acd
commit 967a464a7e
2 changed files with 17 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
tools/perf/ui/browsers/hists.c
View File

@@ -2208,10 +2208,8 @@ static inline bool is_report_browser(void *timer)
return timer == NULL; return timer == NULL;
} }
static int hists_browser__scnprintf_title(struct hist_browser *browser, char *bf, size_t size) int __hists__scnprintf_title(struct hists *hists, char *bf, size_t size, bool show_freq)
{ {
struct hist_browser_timer *hbt = browser->hbt;
struct hists *hists = browser->hists;
char unit; char unit;
int printed; int printed;
const struct dso *dso = hists->dso_filter; const struct dso *dso = hists->dso_filter;
@@ -2254,7 +2252,7 @@ static int hists_browser__scnprintf_title(struct hist_browser *browser, char *bf
strstr(ev_name, "call-graph=no")) strstr(ev_name, "call-graph=no"))
enable_ref = true; enable_ref = true;
if (!is_report_browser(hbt)) if (show_freq)
scnprintf(sample_freq_str, sizeof(sample_freq_str), " %d Hz,", evsel->attr.sample_freq); scnprintf(sample_freq_str, sizeof(sample_freq_str), " %d Hz,", evsel->attr.sample_freq);
nr_samples = convert_unit(nr_samples, &unit); nr_samples = convert_unit(nr_samples, &unit);
@@ -2285,6 +2283,15 @@ static int hists_browser__scnprintf_title(struct hist_browser *browser, char *bf
if (socket_id > -1) if (socket_id > -1)
printed += scnprintf(bf + printed, size - printed, printed += scnprintf(bf + printed, size - printed,
", Processor Socket: %d", socket_id); ", Processor Socket: %d", socket_id);
return printed;
}
static int hists_browser__scnprintf_title(struct hist_browser *browser, char *bf, size_t size)
{
struct hist_browser_timer *hbt = browser->hbt;
int printed = __hists__scnprintf_title(browser->hists, bf, size, !is_report_browser(hbt));
if (!is_report_browser(hbt)) { if (!is_report_browser(hbt)) {
struct perf_top *top = hbt->arg; struct perf_top *top = hbt->arg;

6
tools/perf/util/hist.h
View File

@@ -504,5 +504,11 @@ int __hpp__slsmg_color_printf(struct perf_hpp *hpp, const char *fmt, ...);
int __hist_entry__snprintf(struct hist_entry *he, struct perf_hpp *hpp, int __hist_entry__snprintf(struct hist_entry *he, struct perf_hpp *hpp,
struct perf_hpp_list *hpp_list); struct perf_hpp_list *hpp_list);
int hists__fprintf_headers(struct hists *hists, FILE *fp); int hists__fprintf_headers(struct hists *hists, FILE *fp);
int __hists__scnprintf_title(struct hists *hists, char *bf, size_t size, bool show_freq);
static inline int hists__scnprintf_title(struct hists *hists, char *bf, size_t size)
{
return __hists__scnprintf_title(hists, bf, size, true);
}
#endif /* __PERF_HIST_H */ #endif /* __PERF_HIST_H */