leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

irqchip/realtek-rtl: Service all pending interrupts

Browse Source 
Instead of only servicing the lowest pending interrupt line, make sure
all pending SoC interrupts are serviced before exiting the chained
handler. This adds a small overhead if only one interrupt is pending,
but should prevent rapid re-triggering of the handler.

Signed-off-by: Sander Vanheule <sander@svanheule.net>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/5082ad3cb8b4eedf55075561b93eff6570299fe1.1641739718.git.sander@svanheule.net
This commit is contained in:
Sander Vanheule
2022-01-09 15:54:34 +01:00
committed by Marc Zyngier
parent 91351b5dd0
commit 960dd884dd
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/irqchip/irq-realtek-rtl.c
View File

@@ -76,16 +76,20 @@ static void realtek_irq_dispatch(struct irq_desc *desc)
{ {
struct irq_chip *chip = irq_desc_get_chip(desc); struct irq_chip *chip = irq_desc_get_chip(desc);
struct irq_domain *domain; struct irq_domain *domain;
unsigned int pending; unsigned long pending;
unsigned int soc_int;
chained_irq_enter(chip, desc); chained_irq_enter(chip, desc);
pending = readl(REG(RTL_ICTL_GIMR)) & readl(REG(RTL_ICTL_GISR)); pending = readl(REG(RTL_ICTL_GIMR)) & readl(REG(RTL_ICTL_GISR));
if (unlikely(!pending)) { if (unlikely(!pending)) {
spurious_interrupt(); spurious_interrupt();
goto out; goto out;
} }
domain = irq_desc_get_handler_data(desc); domain = irq_desc_get_handler_data(desc);
generic_handle_domain_irq(domain, __ffs(pending)); for_each_set_bit(soc_int, &pending, 32)
generic_handle_domain_irq(domain, soc_int);
out: out:
chained_irq_exit(chip, desc); chained_irq_exit(chip, desc);