leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

platform_device: use a macro instead of platform_driver_register

Browse Source 
I found a lot of mistakes using struct platform_driver without owner
so I make a macro instead of the function platform_driver_register.
It can set owner in it, then guys don`t care about module owner again.

Signed-off-by: Libo Chen <libo.chen@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Libo Chen 2013-05-25 12:40:50 +08:00 committed by Greg Kroah-Hartman
parent f494513ff1
commit 9447057eaf
2 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/base/platform.c
View File

@ -523,11 +523,13 @@ static void platform_drv_shutdown(struct device *_dev)
} }
/** /**
* platform_driver_register - register a driver for platform-level devices * __platform_driver_register - register a driver for platform-level devices
* @drv: platform driver structure * @drv: platform driver structure
*/ */
int platform_driver_register(struct platform_driver *drv) int __platform_driver_register(struct platform_driver *drv,
struct module *owner)
{ {
drv->driver.owner = owner;
drv->driver.bus = &platform_bus_type; drv->driver.bus = &platform_bus_type;
if (drv->probe) if (drv->probe)
drv->driver.probe = platform_drv_probe; drv->driver.probe = platform_drv_probe;
@ -538,7 +540,7 @@ int platform_driver_register(struct platform_driver *drv)
return driver_register(&drv->driver); return driver_register(&drv->driver);
} }
EXPORT_SYMBOL_GPL(platform_driver_register); EXPORT_SYMBOL_GPL(__platform_driver_register);
/** /**
* platform_driver_unregister - unregister a driver for platform-level devices * platform_driver_unregister - unregister a driver for platform-level devices

8
include/linux/platform_device.h
View File

@ -180,7 +180,13 @@ struct platform_driver {
const struct platform_device_id *id_table; const struct platform_device_id *id_table;
}; };
extern int platform_driver_register(struct platform_driver *); /*
* use a macro to avoid include chaining to get THIS_MODULE
*/
#define platform_driver_register(drv) \
__platform_driver_register(drv, THIS_MODULE)
extern int __platform_driver_register(struct platform_driver *,
struct module *);
extern void platform_driver_unregister(struct platform_driver *); extern void platform_driver_unregister(struct platform_driver *);
/* non-hotpluggable platform devices may use this so that probe() and /* non-hotpluggable platform devices may use this so that probe() and