leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Input: tca8418_keypad - increase severity of failures in probe()

Browse Source 
Failures to build a keymap, request an IRQ, or register input device are
fatal for the driver, therefore the messages should have "error" severity
instead of "debug".

Reviewed-by: Alban Bedel <alban.bedel@avionic-design.de>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
This commit is contained in:
Dmitry Torokhov 2012-11-14 08:20:21 -08:00
parent 5cc0dfe043
commit 91c5d67f17
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/input/keyboard/tca8418_keypad.c
View File

@ -348,7 +348,7 @@ static int tca8418_keypad_probe(struct i2c_client *client,
error = matrix_keypad_build_keymap(keymap_data, NULL, rows, cols,
keypad_data->keymap, input);
if (error) {
dev_dbg(dev, "Failed to build keymap\n");
dev_err(dev, "Failed to build keymap\n");
goto fail2;
}
@ -367,14 +367,14 @@ static int tca8418_keypad_probe(struct i2c_client *client,
IRQF_ONESHOT,
client->name, keypad_data);
if (error) {
dev_dbg(dev, "Unable to claim irq %d; error %d\n",
dev_err(dev, "Unable to claim irq %d; error %d\n",
client->irq, error);
goto fail2;
}
error = input_register_device(input);
if (error) {
dev_dbg(dev, "Unable to register input device, error: %d\n",
dev_err(dev, "Unable to register input device, error: %d\n",
error);
goto fail3;
}