leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

staging: comedi: dt3000: refactor 'adbits' boardinfo

Browse Source 
All the board supported by this driver have analog inputs. The input
resolution is either 12-bit or 16-bit.

Replace the 'adbits' member of the boardinfo with a bit-field flag
'ai_is_16bits' and just set if for the 16-bit boards.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
H Hartley Sweeten 2015-10-08 10:48:23 -07:00 committed by Greg Kroah-Hartman
parent 2943de6ad5
commit 91644956fd
1 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/staging/comedi/drivers/dt3000.c
View File

@ -168,18 +168,17 @@ enum dt3k_boardid {
struct dt3k_boardtype {
const char *name;
int adchan;
int adbits;
int ai_speed;
const struct comedi_lrange *adrange;
int dachan;
int dabits;
unsigned int ai_is_16bit:1;
};
static const struct dt3k_boardtype dt3k_boardtypes[] = {
[BOARD_DT3001] = {
.name = "dt3001",
.adchan = 16,
.adbits = 12,
.adrange = &range_dt3000_ai,
.ai_speed = 3000,
.dachan = 2,
@ -188,7 +187,6 @@ static const struct dt3k_boardtype dt3k_boardtypes[] = {
[BOARD_DT3001_PGL] = {
.name = "dt3001-pgl",
.adchan = 16,
.adbits = 12,
.adrange = &range_dt3000_ai_pgl,
.ai_speed = 3000,
.dachan = 2,
@ -197,14 +195,12 @@ static const struct dt3k_boardtype dt3k_boardtypes[] = {
[BOARD_DT3002] = {
.name = "dt3002",
.adchan = 32,
.adbits = 12,
.adrange = &range_dt3000_ai,
.ai_speed = 3000,
},
[BOARD_DT3003] = {
.name = "dt3003",
.adchan = 64,
.adbits = 12,
.adrange = &range_dt3000_ai,
.ai_speed = 3000,
.dachan = 2,
@ -213,7 +209,6 @@ static const struct dt3k_boardtype dt3k_boardtypes[] = {
[BOARD_DT3003_PGL] = {
.name = "dt3003-pgl",
.adchan = 64,
.adbits = 12,
.adrange = &range_dt3000_ai_pgl,
.ai_speed = 3000,
.dachan = 2,
@ -222,20 +217,20 @@ static const struct dt3k_boardtype dt3k_boardtypes[] = {
[BOARD_DT3004] = {
.name = "dt3004",
.adchan = 16,
.adbits = 16,
.adrange = &range_dt3000_ai,
.ai_speed = 10000,
.dachan = 2,
.dabits = 12,
.ai_is_16bit = 1,
},
[BOARD_DT3005] = {
.name = "dt3005", /* a.k.a. 3004-200 */
.adchan = 16,
.adbits = 16,
.adrange = &range_dt3000_ai,
.ai_speed = 5000,
.dachan = 2,
.dabits = 12,
.ai_is_16bit = 1,
},
};
@ -675,7 +670,7 @@ static int dt3000_auto_attach(struct comedi_device *dev,
s->subdev_flags = SDF_READABLE | SDF_GROUND | SDF_DIFF;
s->n_chan = board->adchan;
s->insn_read = dt3k_ai_insn;
s->maxdata = (1 << board->adbits) - 1;
s->maxdata = board->ai_is_16bit ? 0xffff : 0x0fff;
s->range_table = &range_dt3000_ai; /* XXX */
if (dev->irq) {
dev->read_subdev = s;