leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

reset: mchp: sparx5: fix return value check in mchp_sparx5_map_io()

Browse Source 
In case of error, the function devm_platform_get_and_ioremap_resource()
returns ERR_PTR() and never returns NULL. The NULL test in the return
value check should be replaced with IS_ERR().

Fixes: 453ed4283b ("reset: mchp: sparx5: add switch reset driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20210519141638.3052456-1-weiyongjun1@huawei.com
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
This commit is contained in:
Wei Yongjun
2021-05-19 14:16:37 +00:00
committed by Philipp Zabel
parent 747aeec9ac
commit 91105ed604
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/reset/reset-microchip-sparx5.c
View File

@@ -82,9 +82,9 @@ static int mchp_sparx5_map_io(struct platform_device *pdev, int index,
void __iomem *mem; void __iomem *mem;
mem = devm_platform_get_and_ioremap_resource(pdev, index, &res); mem = devm_platform_get_and_ioremap_resource(pdev, index, &res);
if (!mem) { if (IS_ERR(mem)) {
dev_err(&pdev->dev, "Could not map resource %d\n", index); dev_err(&pdev->dev, "Could not map resource %d\n", index);
return -ENXIO; return PTR_ERR(mem);
} }
sparx5_reset_regmap_config.name = res->name; sparx5_reset_regmap_config.name = res->name;
map = devm_regmap_init_mmio(&pdev->dev, mem, &sparx5_reset_regmap_config); map = devm_regmap_init_mmio(&pdev->dev, mem, &sparx5_reset_regmap_config);